Add a portable XERBLA handler API#5904
Open
moluopro wants to merge 23 commits into
Open
Conversation
imciner2
reviewed
Jul 10, 2026
Collaborator
|
While this looks like a very interesting addition, it still bothers me that it appears to be "only" the utest_ext job that fails to bind the matching xerbla, while the regular BLAS/CBLAS tests appear to manage just fine. |
Contributor
Author
|
Good point. The regular BLAS/CBLAS tests had the same problem, but their failures were not propagated correctly. I have prepared a fix and will push it shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5899 corrected the CTest registration, the Windows ARM64 shared-library job exposed failures in the
xerbla_*extension tests: calls originating in the OpenBLAS DLL did not reach the test executable'sxerblaoverride.#5901 works around this Windows DLL symbol-resolution limitation by switching the CI job to a static build. This PR instead adds an explicit XERBLA handler API for shared-library users and tests, and prevents BLAS and CBLAS error-exit failures from passing silently.
Changes
openblas_set_xerbla, with handler replacement andNULLreset support.