Error on a proc override that shares a path with an existing type#2681
Open
mumencoder wants to merge 1 commit into
Open
Error on a proc override that shares a path with an existing type#2681mumencoder wants to merge 1 commit into
mumencoder wants to merge 1 commit into
Conversation
BYOND makes no distinction between the path of a type and the path of a proc override, since an override is written without a "proc" keyword. Declaring /datum/test/beep and then defining /datum/test/beep() is a duplicate definition there, while OpenDream happily accepted both. Verified against BYOND 516.1685 that this only applies to the override form and only when the type comes first: "/datum/test/proc/beep()" next to a "/datum/test/beep" type compiles either way, and so does an override followed by the type declaration. Tests/Procs/final_proc2.dm had this exact conflict and does not compile in BYOND, so its procs named "final" are moved above the point where /datum/test/final becomes a type. Fixes OpenDreamProject#2648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BYOND makes no distinction between the path of a type and the path of a proc override, since an override is written without a "proc" keyword. Declaring /datum/test/beep and then defining /datum/test/beep() is a duplicate definition there, while OpenDream happily accepted both.
Verified against BYOND 516.1685 that this only applies to the override form and only when the type comes first: "/datum/test/proc/beep()" next to a "/datum/test/beep" type compiles either way, and so does an override followed by the type declaration.
Tests/Procs/final_proc2.dm had this exact conflict and does not compile in BYOND, so its procs named "final" are moved above the point where /datum/test/final becomes a type.
Fixes #2648