fix issue #2675#2677
Open
mumencoder wants to merge 1 commit into
Open
Conversation
Member
If this is true then you could replace all these switches with an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2675
Problem
Comparing a number with a resource (e.g.
0 == 'sound/weapons/metalhit.ogg')threw
NotImplementedException: Equal comparison for 0 and '...' is not implementedat runtime instead of evaluating to
FALSE.Fix
In DM, values of different types are never
==-equal, so each inner switch nowfalls back to
return false(mirroring the existingDreamResource/Appearancebranches) instead of throwing. This covers the whole class of cross-type
comparisons, and
!=/~=inherit the fix since they route throughIsEqual.