Misc Parity Fixes - #2669
Open
ike709 wants to merge 9 commits into
Open
Conversation
boring-cyborg
Bot
added
Compiler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // BYOND's one-dimensional list produces null when its runtime size is negative | ||
| // This is different from multidimensional lists, where the negative dimensions become zero | ||
| if (dimensionCount == 1 && dimensionSizes[0].TryGetValueAsInteger(out int size) && size < 0) { | ||
| dimensionSizes[0].Dispose(); |
Member
|
I think you've encountered a refcounting bug in BYOND with this one |
Collaborator
Author
|
I slapped |
wixoaGit
requested changes
Jul 27, 2026
| using var associativeValue = list.GetValue(value); | ||
| foreach (DreamValue value in list.EnumerateValues()) { | ||
| bool retained = secondList?.ContainsValue(value) ?? value == second; | ||
| if (!retained || !retainedValues.Add(value)) |
Member
There was a problem hiding this comment.
list(1, 1, 1) & list(1, 1) should give you list(1, 1). The way this HashSet is used, you'd only get list(1).
Co-authored-by: wixoa <wixoag@gmail.com>
Co-authored-by: wixoa <wixoag@gmail.com>
Co-authored-by: wixoa <wixoag@gmail.com>
wixoaGit
reviewed
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the new unit tests were passing in BYOND but not in OpenDream prior to these changes.