Adds PreIncrement & PreDecrement opcodes; fixes comparison operators#2666
Open
ike709 wants to merge 4 commits into
Open
Adds PreIncrement & PreDecrement opcodes; fixes comparison operators#2666ike709 wants to merge 4 commits into
PreIncrement & PreDecrement opcodes; fixes comparison operators#2666ike709 wants to merge 4 commits into
Conversation
boring-cyborg
Bot
added
Compiler
ike709
changed the title
PreIncrement & PreDecrement opcodesPreIncrement & PreDecrement opcodes; fixes comparison operators
wixoaGit
requested changes
Jul 22, 2026
Comment on lines
+2999
to
+3004
| private static bool IsReferenceComparisonType(DreamValue.DreamValueType type) { | ||
| return type is DreamValue.DreamValueType.DreamObject or | ||
| DreamValue.DreamValueType.DreamProc or | ||
| DreamValue.DreamValueType.DreamResource or | ||
| DreamValue.DreamValueType.DreamType; | ||
| } |
Member
There was a problem hiding this comment.
I don't like the maintainability issue this creates. BYOND doesn't make this sort of "reference type" distinction, would it be more accurate to say this applies to anything that isn't a number, null, or string?
Collaborator
Author
There was a problem hiding this comment.
Probably? I'd need to find time this weekend for further testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new unit tests passed in BYOND but not OpenDream.
This fixes
++/--the parity issue by creating dedicatedPreIncrement/PreDecrementopcodes with matching behavior. Deduplicated the opcode handlers with a shared helper method.This also fixes the greater than / less than comparison operators (and the "or equals to" variants) with some types.