Skip to content

schema mapping for api#24261

Draft
jpfinne wants to merge 14 commits into
OpenAPITools:masterfrom
jpfinne:bugfix/schemaMappingForApi
Draft

schema mapping for api#24261
jpfinne wants to merge 14 commits into
OpenAPITools:masterfrom
jpfinne:bugfix/schemaMappingForApi

Conversation

@jpfinne

@jpfinne jpfinne commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes missing imports for schema-mapped parameter types in API generation, ensuring importMapping is honored when using --schema-mappings (fixes #24232).

  • Bug Fixes
    • In DefaultCodegen.fromOperation, add mapped parameter dataType tokens to op.imports when present in importMapping, so the correct fully qualified imports are emitted.
    • Added a Spring test and OpenAPI fixture to verify imports of org.myorg.MyCustomId and org.myorg.MyCustomKey are generated in SomeApi.java and Dummy.java.

Written for commit a5c2798. Summary will update on new commits.

Review in cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA] [SPRING] missing import for schemaMapping in api

1 participant