Skip to content

[backend] feat(chaining): add type for payload arguments (#4824) - #5302

Merged
Stephanya Casanova (savacano28) merged 14 commits into
release/currentfrom
issue/4824-type-payload-arguments
Apr 20, 2026
Merged

[backend] feat(chaining): add type for payload arguments (#4824)#5302
Stephanya Casanova (savacano28) merged 14 commits into
release/currentfrom
issue/4824-type-payload-arguments

Conversation

@savacano28

@savacano28 Stephanya Casanova (savacano28) commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

  • Add type and subtypes (non mandatory) for payload arguments (UI/back)
  • Add ff for these new values
image image image

Testing Instructions

  1. Create a payload
  2. Add arguments of different type
  3. Test payload
  4. Modify payload arguments
  5. Export payload
  6. Import Payload

Related issues

What is not covered in this Pr:

  • Validation type for paylaod arguments, even if we set a type we dont check if the values correspondent to type, x: ip -> 1111 Invalid
  • Endpoint to fetch all payloadArgumentTypes
  • Endpoint to fetch injects with payloadArgument related to ContractOutputTypes

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 Stephanya Casanova (savacano28) added the filigran team Item from the Filigran team. label Mar 31, 2026
@savacano28
Stephanya Casanova (savacano28) marked this pull request as ready for review March 31, 2026 13:05
@savacano28
Stephanya Casanova (savacano28) force-pushed the issue/4824-type-payload-arguments branch from 33a177b to cc53733 Compare March 31, 2026 13:10
@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.84%. Comparing base (fd0912b) to head (74e699e).
⚠️ Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...v/rest/inject/service/ExecutableInjectService.java 0.00% 1 Missing and 1 partial ⚠️
...ain/java/io/openaev/rest/payload/PayloadUtils.java 33.33% 1 Missing and 1 partial ⚠️
...penaev/rest/payload/exports/PayloadFileExport.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #5302      +/-   ##
=====================================================
+ Coverage              63.83%   63.84%   +0.01%     
- Complexity              5784     5789       +5     
=====================================================
  Files                   1135     1138       +3     
  Lines                  34030    34039       +9     
  Branches                2624     2624              
=====================================================
+ Hits                   21722    21732      +10     
+ Misses                 11031    11030       -1     
  Partials                1277     1277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camrrx
Camille Roux (camrrx) self-requested a review April 1, 2026 08:02
@savacano28 Stephanya Casanova (savacano28) changed the title [backend] feat: add type for payload arguments (#4824) [backend] feat(chaining): add type for payload arguments (#4824) Apr 1, 2026
Comment thread openaev-front/src/admin/components/payloads/form/PayloadArgumentsField.tsx Outdated
Comment thread openaev-front/src/admin/components/payloads/form/PayloadArgumentsField.tsx Outdated
@savacano28
Stephanya Casanova (savacano28) force-pushed the issue/4824-type-payload-arguments branch 3 times, most recently from 0e51c4c to ed477cc Compare April 3, 2026 10:24
@camrrx
Camille Roux (camrrx) force-pushed the issue/4824-type-payload-arguments branch from 9a81612 to a1c49dd Compare April 13, 2026 09:12
@savacano28
Stephanya Casanova (savacano28) force-pushed the issue/4824-type-payload-arguments branch 4 times, most recently from cf343a6 to 9a7cd06 Compare April 17, 2026 07:25
@savacano28
Stephanya Casanova (savacano28) force-pushed the issue/4824-type-payload-arguments branch from 9a7cd06 to c201ced Compare April 17, 2026 08:56
# Conflicts:
#	openaev-api/src/main/java/io/openaev/rest/payload/exports/PayloadFileExport.java
#	openaev-api/src/test/java/io/openaev/rest/payload/PayloadApiTest.java
#	openaev-front/src/admin/components/threat_arsenal/form/useArgumentTypes.ts
#	openaev-front/tests_e2e/model/threat-arsenals/ThreatArsenalFormComponent.ts
#	openaev-front/tests_e2e/tests/payloads/payload-creation.spec.ts
@savacano28
Stephanya Casanova (savacano28) merged commit 497c74b into release/current Apr 20, 2026
14 checks passed
@savacano28
Stephanya Casanova (savacano28) deleted the issue/4824-type-payload-arguments branch April 20, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants