Skip to content

[clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191) - #192

Merged
Mariot Tsitoara (mariot) merged 1 commit into
release/currentfrom
191-add-new-contractoutputtype
Apr 8, 2026
Merged

[clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191)#192
Mariot Tsitoara (mariot) merged 1 commit into
release/currentfrom
191-add-new-contractoutputtype

Conversation

@Seb-MIGUEL

Copy link
Copy Markdown
Contributor

Summary

  • Add 13 new ContractOutputType enum values to support structured finding extraction beyond text and credentials
  • New types: Username, Share, AdminUsername, Group, Computer, PasswordPolicy, Delegation, Sid, Vulnerability, AccountWithPasswordNotRequired, AsreproastableAccount, KerberoastableAccount
  • These allow injectors to produce domain-specific findings instead of generic text output

Rationale

  • Credentials should only represent reusable secrets (passwords, NTLM hashes, Kerberos keys)
  • Kerberoasting/AS-REP roasting hashes are crackable material, not directly reusable credentials — they now have their own finding types
  • Enumeration results (users, groups, shares, etc.) deserve specific types for proper filtering, display, and aggregation in the platform
  • Vulnerability detections (Spooler enabled, LDAP signing not enforced, etc.) need a dedicated type separate from generic text

Backward Compatibility

No existing enum values were removed or renamed. This is purely additive.

Closes #191

  Add 13 new enum values (Credentials, Username, Share, AdminUsername,
  Group, Computer, PasswordPolicy, Delegation, Sid, Vulnerability,
  AccountWithPasswordNotRequired, AsreproastableAccount,
  KerberoastableAccount) to support domain-specific finding extraction.

  Closes #191
@Seb-MIGUEL Sébastien MIGUEL (Seb-MIGUEL) linked an issue Mar 5, 2026 that may be closed by this pull request
@Seb-MIGUEL Sébastien MIGUEL (Seb-MIGUEL) changed the title feat: add new ContractOutputType values for structured findings [client] feat: add new ContractOutputType values for structured findings Mar 5, 2026
@Seb-MIGUEL Sébastien MIGUEL (Seb-MIGUEL) changed the title [client] feat: add new ContractOutputType values for structured findings [client-python] feat: add new ContractOutputType values for structured findings Mar 5, 2026
@mariot Mariot Tsitoara (mariot) changed the title [client-python] feat: add new ContractOutputType values for structured findings [client-python] feat(contracts): add new ContractOutputType values for structured findings (#191) Mar 5, 2026
@mariot Mariot Tsitoara (mariot) changed the title [client-python] feat(contracts): add new ContractOutputType values for structured findings (#191) [clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191) Mar 5, 2026
@ncarenton Nicolas Carenton (ncarenton) added the do not merge Do not merge until this label is removed. label Mar 16, 2026
@ncarenton
Nicolas Carenton (ncarenton) changed the base branch from main to release/current March 17, 2026 08:18
@mariot
Mariot Tsitoara (mariot) merged commit 5bf4ce1 into release/current Apr 8, 2026
15 checks passed
@mariot
Mariot Tsitoara (mariot) deleted the 191-add-new-contractoutputtype branch April 8, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Do not merge until this label is removed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add New contractoutputtype

4 participants