[18.0][IMP] fs_attachment: two attachments with same name and content - #640
Open
CRogos wants to merge 1 commit into
Open
[18.0][IMP] fs_attachment: two attachments with same name and content#640CRogos wants to merge 1 commit into
CRogos wants to merge 1 commit into
Conversation
Contributor
|
Hi @lmignon, |
CRogos
force-pushed
the
18.0-imp-fs_attachment-duplicate-name
branch
from
July 7, 2026 16:06
e18314f to
a7a8b9f
Compare
CRogos
marked this pull request as ready for review
July 8, 2026 07:31
lmignon
requested changes
Jul 15, 2026
lmignon
left a comment
lmignon
left a comment
Contributor
There was a problem hiding this comment.
Thank you for pointing out this use case, which I hadn't anticipated.
There are several factors to consider:
- The same file with the same name can be created in different calls to “create.” (This case is not handled.)
- We need to ensure that deleting an attachment does not delete the file referenced by other attachments (this should not be the case with the garbage collector mechanism)
- We need to ensure that if I write directly to the file (my_file.open()), only the attachment I wrote to is modified. (This should be the case)
Comment on lines
+445
to
+450
| self.ir_attachment_model.create( | ||
| [ | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| ] | ||
| ) |
Contributor
There was a problem hiding this comment.
Can you check you've 2 attachment records with 2 different files. If I update one file, the other one should not be changed.
Comment on lines
+436
to
+441
| self.ir_attachment_model.create( | ||
| [ | ||
| {"name": "test2.txt", "raw": b"content"}, | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| ] | ||
| ) |
Contributor
There was a problem hiding this comment.
OK the command create works but can you check the result. Otherwise your tests is partially useless....
Contributor
Author
There was a problem hiding this comment.
The previous result was an exception, but I agree we should so some check.
CRogos
force-pushed
the
18.0-imp-fs_attachment-duplicate-name
branch
from
July 15, 2026 10:58
7e721f0 to
d58b1d0
Compare
CRogos
force-pushed
the
18.0-imp-fs_attachment-duplicate-name
branch
from
July 15, 2026 11:07
d58b1d0 to
29894f3
Compare
CRogos
commented
Jul 15, 2026
Comment on lines
+436
to
+441
| self.ir_attachment_model.create( | ||
| [ | ||
| {"name": "test2.txt", "raw": b"content"}, | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| ] | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
The previous result was an exception, but I agree we should so some check.
Comment on lines
+445
to
+450
| self.ir_attachment_model.create( | ||
| [ | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| {"name": "test.txt", "raw": b"content"}, | ||
| ] | ||
| ) |
CRogos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to: #639