Skip to content

ncdu: 2.9.2 -> 2.10.0, update source#537648

Open
tree-sapii wants to merge 1 commit into
NixOS:masterfrom
tree-sapii:push-xwurlupqnuvu
Open

ncdu: 2.9.2 -> 2.10.0, update source#537648
tree-sapii wants to merge 1 commit into
NixOS:masterfrom
tree-sapii:push-xwurlupqnuvu

Conversation

@tree-sapii

Copy link
Copy Markdown
Contributor

Things done

Per the discussion here, @BratishkaErik maintains a fork of the package at https://github.com/BratishkaErik/ncdu, so its better to just move the source as the original website could be going down as described in #536471 .

@nixpkgs-ci nixpkgs-ci Bot requested review from Defelo, pSub, rodrgz and ryan4yin July 2, 2026 03:26
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 2, 2026
@nixpkgs-review-gha

Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha (da739d6)

Command: nixpkgs-review pr 537648
Commit: a33cd15d6429d8e72eff9b91ae7cdcbd68df6218 (subsequent changes)
Merge: 925351104e79963e3866b22a0972a35578f965d7

Triggered by @tree-sapii (144389458)
Logs: https://github.com/tree-sapii/nixpkgs-review-gha/actions/runs/28562992890/attempts/1


x86_64-linux

✅ 2 packages built:
  • ncdu
  • ncdu_1

aarch64-linux

✅ 2 packages built:
  • ncdu
  • ncdu_1

x86_64-darwin

No rebuilds


aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • ncdu
  • ncdu_1

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ncdu package to a newer upstream release and switches the source to the maintained GitHub fork, motivated by concerns that the original upstream hosting may become unavailable.

Changes:

  • Bump ncdu from 2.9.2 to 2.10.0 and switch src/metadata URLs to github.com/BratishkaErik/ncdu.
  • Update the Zig-based build to use zig_0_16 and introduce dependency fetching via zig.fetchDeps.
  • Replace the bespoke updater script with nix-update-script, and update the 1.x derivation to fetch from GitHub (adding autoreconfHook).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pkgs/by-name/nc/ncdu/update.sh Removes the old updater script (replaced by nix-update-script in package.nix).
pkgs/by-name/nc/ncdu/package.nix Updates ncdu to 2.10.0, switches source to GitHub fork, updates Zig/tooling and metadata.
pkgs/by-name/nc/ncdu/1.nix Switches the 1.22 derivation to fetch from the GitHub fork and adds autoreconfHook for building from a VCS source.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkgs/by-name/nc/ncdu/package.nix
@tree-sapii tree-sapii force-pushed the push-xwurlupqnuvu branch from a33cd15 to 46f9e20 Compare July 2, 2026 04:03
@tree-sapii

Copy link
Copy Markdown
Contributor Author

Note: earlier I found out that suggestion above doesn't. Please try it tho.

Comment thread pkgs/by-name/nc/ncdu/1.nix Outdated
Comment thread pkgs/by-name/nc/ncdu/1.nix
Comment thread pkgs/by-name/nc/ncdu/package.nix Outdated
Comment thread pkgs/by-name/nc/ncdu/package.nix

@SandaruKasa SandaruKasa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not qualified enough to review the zig changes, sadly.

Also it's strange that there is no "has-package-update" label on the pr.

@tree-sapii

Copy link
Copy Markdown
Contributor Author

Hmm it seems the nixd fetchFromGitHub autocomplete still uses rev instead of tag and I didn't notice haha.

@tree-sapii tree-sapii force-pushed the push-xwurlupqnuvu branch from 46f9e20 to 489562d Compare July 2, 2026 18:42
@nixpkgs-review-gha

Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha (da739d6)

Command: nixpkgs-review pr 537648
Commit: 489562d3b1e895ac40b02ae8766093095b27641d (subsequent changes)
Merge: 45b0fabdacbf4cd5aa1641ed34d90565ad94c145

Triggered by @tree-sapii (144389458)
Logs: https://github.com/tree-sapii/nixpkgs-review-gha/actions/runs/28562992890/attempts/2


x86_64-linux

✅ 2 packages built:
  • ncdu
  • ncdu_1

aarch64-linux

✅ 2 packages built:
  • ncdu
  • ncdu_1

x86_64-darwin

No rebuilds


aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • ncdu
  • ncdu_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants