ncdu: 2.9.2 -> 2.10.0, update source#537648
Conversation
✅
|
There was a problem hiding this comment.
Pull request overview
This PR updates the ncdu package to a newer upstream release and switches the source to the maintained GitHub fork, motivated by concerns that the original upstream hosting may become unavailable.
Changes:
- Bump
ncdufrom2.9.2to2.10.0and switchsrc/metadata URLs togithub.com/BratishkaErik/ncdu. - Update the Zig-based build to use
zig_0_16and introduce dependency fetching viazig.fetchDeps. - Replace the bespoke updater script with
nix-update-script, and update the1.xderivation to fetch from GitHub (addingautoreconfHook).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkgs/by-name/nc/ncdu/update.sh | Removes the old updater script (replaced by nix-update-script in package.nix). |
| pkgs/by-name/nc/ncdu/package.nix | Updates ncdu to 2.10.0, switches source to GitHub fork, updates Zig/tooling and metadata. |
| pkgs/by-name/nc/ncdu/1.nix | Switches the 1.22 derivation to fetch from the GitHub fork and adds autoreconfHook for building from a VCS source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a33cd15 to
46f9e20
Compare
|
Note: earlier I found out that suggestion above doesn't. Please try it tho. |
SandaruKasa
left a comment
There was a problem hiding this comment.
Not qualified enough to review the zig changes, sadly.
Also it's strange that there is no "has-package-update" label on the pr.
|
Hmm it seems the nixd fetchFromGitHub autocomplete still uses rev instead of tag and I didn't notice haha. |
46f9e20 to
489562d
Compare
✅
|
Things done
Per the discussion here, @BratishkaErik maintains a fork of the package at https://github.com/BratishkaErik/ncdu, so its better to just move the source as the original website could be going down as described in #536471 .
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.