Skip to content

Fix Python platform argument matching - #5203

Draft
flowerthrower wants to merge 1 commit into
NVIDIA:mainfrom
flowerthrower:fix/python-platform-argument-matching
Draft

Fix Python platform argument matching#5203
flowerthrower wants to merge 1 commit into
NVIDIA:mainfrom
flowerthrower:fix/python-platform-argument-matching

Conversation

@flowerthrower

@flowerthrower flowerthrower commented Aug 20, 2026

Copy link
Copy Markdown

Summary

  • accept each target argument's platform-arg as a Python/runtime key
  • retain the existing config-key and prefixed nvq++ spellings
  • restore documented Python kwargs for existing backends such as Scaleway, IonQ, and IQM

Testing

  • uvx prek run --files cudaq/lib/Target/Yaml/TargetConfigYaml.cpp
  • focused C++ comparison using setup-mlir 22.1.4:
    • unmodified main drops Scaleway's max_duration
    • patched code forwards Scaleway's max_duration, IonQ's qpu, and IQM's url
    • patched code retains --scaleway-max-duration
  • git diff --check

Context

This also addresses the target-argument mismatch identified while reviewing #4882 and fixes #5202

Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python set_target silently ignores arguments whose YAML keys contain hyphens

1 participant