[Common] Ensure quantization kernels handle noop properly - #3271
Open
kainzhong wants to merge 3 commits into
Open
[Common] Ensure quantization kernels handle noop properly#3271kainzhong wants to merge 3 commits into
kainzhong wants to merge 3 commits into
Conversation
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryThis PR corrects noop handling across quantization kernels.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Update transformer_engine/common/cast/mx..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Kaining Zhong <44538064+kainzhong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When quantization kernels are fused with act / dact / dbias, they should ignore the noop flag. Currently we mostly rely on the caller passing the right noop flag but we don't have guards in the kernel.
Type of change
Changes
Please list the changes introduced in this PR:
IS_DBIAS. Alsozero_scales_kernelnow will ignore noop when the quantization ignores it (otherwise if we skip zeroing but not skip quantization the result could be wrong)Checklist: