Skip to content

[Main] Support device-init grouped linear module too with when not using TE opfuser - #6000

Open
zhongbozhu wants to merge 6 commits into
NVIDIA:mainfrom
zhongbozhu:main_support_device_group_linear
Open

[Main] Support device-init grouped linear module too with when not using TE opfuser#6000
zhongbozhu wants to merge 6 commits into
NVIDIA:mainfrom
zhongbozhu:main_support_device_group_linear

Conversation

@zhongbozhu

@zhongbozhu zhongbozhu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Proper single weight support, discrete weight is not affected. Adds many numerical unit tests running on GB200.

Unit testing:

Note: some tests can only run with TE updated (NVIDIA/TransformerEngine#3224), for CI image, it should just pass without causing errors.

pytest -s -v --confcutdir=tests/unit_tests/transformer/moe tests/unit_tests/transformer/moe/test_grouped_mlp.py

torchrun --nproc_per_node=4 --log-dir /tmp/mcore-single-weight-ut --tee 0:3 --redirects 3 -m pytest -s -v --confcutdir=tests/unit_tests/transformer/moe tests/unit_tests/transformer/moe/test_moe_single_grouped_weight_numerics.py

torchrun --nproc_per_node=4 --log-dir /tmp/mcore-grouped-dispatcher-ut --tee 0:3 --redirects 3 -m pytest -s -v --confcutdir=tests/unit_tests/transformer/moe tests/unit_tests/transformer/moe/test_grouped_tensor_dispatcher_numerics.py

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
@zhongbozhu
zhongbozhu force-pushed the main_support_device_group_linear branch from 944cb4e to a78c12b Compare August 1, 2026 00:55
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
@zhongbozhu
zhongbozhu marked this pull request as ready for review August 1, 2026 09:12
@zhongbozhu
zhongbozhu requested review from a team as code owners August 1, 2026 09:12
@zhongbozhu

Copy link
Copy Markdown
Contributor Author

/ok to test 1f647e6

Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants