Skip to content

MCR-3771 set internal sourcepath of derivate to NULL on create#3056

Open
rsteph-de wants to merge 2 commits into
2024.06.xfrom
issues/MCR-3771-set_internal_sourcepath_of_derivate_to_NULL
Open

MCR-3771 set internal sourcepath of derivate to NULL on create#3056
rsteph-de wants to merge 2 commits into
2024.06.xfrom
issues/MCR-3771-set_internal_sourcepath_of_derivate_to_NULL

Conversation

@rsteph-de

Copy link
Copy Markdown
Member

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Bugfix-Specific Checks

  • Affected version is listed in the ticket.
  • Minimal code changes were made (no refactoring).
  • This PR truly fixes only the reported bug.
  • No breaking changes are introduced.
  • A relevant test was added (if feasible).

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@rsteph-de
rsteph-de requested review from sebhofmann and yagee-de July 20, 2026 17:08
@rsteph-de

rsteph-de commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

This is a suggestion that works for me in 2026.06 LTS - but
someone with more experience regarding the MCRMetadataManager should have a closer look!!!
starting with 2024.06 the related code parts are nearly unchanged till main (easy merge)
If this should be fixed in 2023.06 as well - more work is needed.

@rsteph-de
rsteph-de marked this pull request as draft July 21, 2026 09:07
@rsteph-de
rsteph-de marked this pull request as ready for review July 21, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant