MCR-3764 Warn about missing or deprecated classes in configuration#3048
MCR-3764 Warn about missing or deprecated classes in configuration#3048yagee-de wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f7de7eeba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| private static boolean isClassProperty(String key, String value, Pattern classPattern) { | ||
| return key.endsWith(".Class") || classPattern.matcher(value).find(); |
There was a problem hiding this comment.
Include lowercase class suffixes in the scan
When an application configures a custom class using the supported lowercase .class suffix (for example Foo.Bar.class=com.acme.Missing), this predicate returns false unless the value also matches the org.mycore regex. The configurable-instance code treats .Class and .class equivalently, so valid lowercase properties in non-MyCoRe packages are never included in the startup report, defeating the new missing/deprecated-class check for those extension configs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
".class" does not respect the mycore.properties naming scheme for properties. After a '.' a capital letter must follow if not other circumstances require a lower case letter. But for configured classes this is not the case so only ".Class" is supported.
There was a problem hiding this comment.
Well, this is only the case since MCR-3670, so only in 2026.06.x and later. In 2025.06.x we still have, for example:
MCR.Crypt.Cipher.accesskey.class=...MCR.LayoutService.FoFormatter.class=...
Link to jira.
Pull Request Checklist (Author)
Please go through the following checklist before assigning the PR for review:
Ticket & Documentation
fixed-versionis correctly set in the ticket and matches the PR's target branch (main).Feature & Improvement Specific Checks
Bugfix-Specific Checks
Testing
MCR Conventions & Metadata
mycore.properties.mycore.properties.Multi-Repo Considerations
MIRrequired?