Skip to content

Fix Collection Case Action Sounds Playing for Other Players - Fix #143 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Awakened-Redstone merged 3 commits into from
Jul 17, 2026
Merged

Fix Collection Case Action Sounds Playing for Other Players - Fix #143 #147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3e4ce2
Fix: Fix Collection Case sounds being played to other players & preve…
Superkat32 Jul 15, 2026
774eac1
Revert: Undo no scrolling if it isn't possible to scroll
Superkat32 Jul 15, 2026
bf7b620
Refactor: Readd tooltip super method call
Superkat32 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/main/java/dev/hephaestus/glowcase/item/CollectionCaseItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import dev.hephaestus.glowcase.Glowcase;
import dev.hephaestus.glowcase.item.component.CollectionComponent;
import dev.hephaestus.glowcase.util.CollectableStack;
import java.util.List;
import java.util.function.Consumer;
import net.minecraft.ChatFormatting;
import net.minecraft.network.chat.Component;
Expand Down Expand Up @@ -31,23 +30,23 @@ public boolean bundleInteract(ItemStack caseStack, ItemStack otherStack, ClickAc
if (!retrievedStack.isEmpty() && collection.isSelectedCollected()) { // Retrieve Collectable
otherStackSetter.accept(retrievedStack);
caseStack.set(Glowcase.COLLECTION_COMPONENT.get(), collection.retrieveSelectedStack(player.isCreative()));
playRetrieveSound(player);
if (player.isLocalPlayer()) playRetrieveSound(player);
return true;
} else if (player.isCreative() && tooltipVisible && collection.hasSelection()) { // Remove Collectable
caseStack.set(Glowcase.COLLECTION_COMPONENT.get(), collection.withoutSelectedStack());
playRemoveSound(player);
if (player.isLocalPlayer()) playRemoveSound(player);
return true;
}
} else { // Insertion Actions
int collectionIndex = collection.getCollectionIndex(otherStack);
if (collectionIndex != -1) { // Collect Collectable
otherStack.shrink(collection.collectables().get(collectionIndex).getStack().getCount());
caseStack.set(Glowcase.COLLECTION_COMPONENT.get(), collection.collectStack(collectionIndex));
playCollectSound(player);
if (player.isLocalPlayer()) playCollectSound(player);
return true;
} else if (player.isCreative()) { // Add Collectable
caseStack.set(Glowcase.COLLECTION_COMPONENT.get(), collection.withStackAfterSelection(otherStack));
playAddSound(player);
if (player.isLocalPlayer()) playAddSound(player);
return true;
}
}
Expand Down Expand Up @@ -80,14 +79,14 @@ public void scroll(ItemStack caseStack, Player player, int amount) {
}
caseStack.set(Glowcase.COLLECTION_COMPONENT.get(), collection);
}
playScrollSound(player);
if (player.isLocalPlayer()) playScrollSound(player);
}
}

@Override
public void appendHoverText(ItemStack stack, TooltipContext context, TooltipDisplay displayComponent, Consumer<Component> textConsumer, TooltipFlag type) {
super.appendHoverText(stack, context, displayComponent, textConsumer, type);

CollectionComponent collection = stack.get(Glowcase.COLLECTION_COMPONENT.get());
textConsumer.accept(Component.translatable("item.glowcase.collection_case.tooltip.0").withStyle(ChatFormatting.GRAY));
if (type.isCreative()) textConsumer.accept(Component.translatable("item.glowcase.collection_case.tooltip.creative.0").withStyle(ChatFormatting.DARK_GRAY));
Expand Down
Loading