Skip to content

fix: remove bad practice Overwrite #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Awakened-Redstone merged 1 commit into from
Jul 6, 2026
Merged

fix: remove bad practice Overwrite #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ authors=HavenKing, ModFest
contributors=Sisby folk, Sammy.K, Chai, dooiji, Superkat32, Hyperpigeon, ShiroJR, maximumpower55, CallMeEcho, quaternary, afamiliarquiet, Emi, comp500, LemmaEOF, acikek, hammy275, TheEpicBlock, Tomate0613, SkyNotTheLimit, Patbox, AmyMialee, Ampflower, Awakened Redstone
license=CC0-1.0
# Mod Version
baseVersion=2.5.4
baseVersion=2.5.5
# Branch Metadata
branch=26.1
tagBranch=26.1
Expand Down
16 changes: 8 additions & 8 deletions src/main/java/dev/hephaestus/glowcase/mixin/client/CompactVectorArrayMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
package dev.hephaestus.glowcase.mixin.client;

import com.llamalad7.mixinextras.expression.Definition;import com.llamalad7.mixinextras.expression.Expression;
import com.llamalad7.mixinextras.injector.ModifyExpressionValue;
import com.mojang.blaze3d.vertex.CompactVectorArray;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Overwrite;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;

@Mixin(CompactVectorArray.class)
public class CompactVectorArrayMixin {
@Shadow @Final private float[] contents;

/**
* @author Awakened Redstone (Luna)
* @reason Fix bug on vanilla method
*/
@Overwrite
public float getZ(final int index) {
return this.contents[3 * index + 2];
@Definition(id = "contents", field = "Lcom/mojang/blaze3d/vertex/CompactVectorArray;contents:[F")
@Expression("this.contents[? + @(1)]")
@ModifyExpressionValue(method = "getZ", at = @At("MIXINEXTRAS:EXPRESSION"))
public int getZ(int original) {
return 2;
}
}
Loading