Warn about syntax the tree-sitter parser will not accept - #1059
Draft
Dekker1 wants to merge 1 commit into
Draft
Conversation
`op` will become a reserved word, but the bison lexer accepts it as an identifier. `==` and `=` are also the same token, so `var bool: x == e` is silently a definition rather than the comparison it looks like. Warn about both so that models can be fixed before the parser is replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
opwill become a reserved word, but the bison lexer accepts it as anidentifier.
==and=are also the same token, sovar bool: x == eissilently a definition rather than the comparison it looks like. Warn about
both so that models can be fixed before the parser is replaced.
Checklist