Refactor: media output path resolution + removal of --custom_folders CLI flag and config option - #4969
Open
behackl wants to merge 26 commits into
Open
Refactor: media output path resolution + removal of --custom_folders CLI flag and config option#4969behackl wants to merge 26 commits into
--custom_folders CLI flag and config option#4969behackl wants to merge 26 commits into
Conversation
behackl
added
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: nikolajmunk <28557236+nikolajmunk@users.noreply.github.com>
…out-output-plan # Conflicts: # docs/source/guides/deep_dive.rst # tests/test_scene_rendering/opengl/test_cli_flags_opengl.py # tests/test_scene_rendering/test_file_writer.py
Member
Author
|
Improved documentation etc. in the same spirit as #4966 in the latest commits; also merged the newer version of this PR into here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #4966, actual diff: behackl/manim@refactor/output-session-config...refactor/media-layout-output-plan
This moves media layout and output-path decisions out of
SceneFileWriter. Each scene now resolves one immutableOutputPlanbefore renderer initialization, covering the primary artifact, fallback PNG, image sequence, silent segment cache, sections, subtitles, and concat manifest.The writer receives this plan explicitly and creates directories only when an operation actually writes to them. File-log path setup also moves out of the writer.
Behavior changes
--output_fileis accepted only when rendering exactly one scene. Combining it with--write_allor multiple selected scenes now fails clearly.movie.mp4remainsmovie.mp4, whilemovie.movwith MP4 output becomesmovie.mov.mp4.--custom_folders,config.custom_folders, and the[custom_folders]preset are removed. Configure the existingmedia_dir,video_dir,images_dir,sections_dir,partial_movie_dir, and related options directly instead.SceneFileWriterimplementations must accept the new explicitoutput_planargument.This does not change codecs, encoder settings, cache identity, audio handling, or render scheduling. Those remain follow-up work once the writer has been detached from renderer and global configuration state.