Skip to content

Fix: OpenGL init for StealthTip - #4959

Open
christopher-hampson wants to merge 2 commits into
ManimCommunity:mainfrom
christopher-hampson:fix_opengl_stealth_tip
Open

Fix: OpenGL init for StealthTip#4959
christopher-hampson wants to merge 2 commits into
ManimCommunity:mainfrom
christopher-hampson:fix_opengl_stealth_tip

Conversation

@christopher-hampson

Copy link
Copy Markdown
Contributor

Overview: What does this pull request change?

Fixes StealthTip initialization when using the OpenGL renderer.

Previous initialization bypassed ConvertToOpenGL metaclass, which results in the following error

AttributeError: 'StealthTip' object has no attribute 'data'

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

self.start_angle = start_angle
VMobject.__init__(
self, fill_opacity=fill_opacity, stroke_width=stroke_width, **kwargs
super(ArrowTip, self).__init__(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there might be a nicer fix for this - happy to take any suggestions, this just seemed like the smallest patch that seemed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants