Skip to content

[Experimental] Fix regression tests in test_vectorized_mobject.py #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmuenkel wants to merge 1 commit into
base: experimental
Choose a base branch
from
Open

[Experimental] Fix regression tests in test_vectorized_mobject.py #4922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from collections.abc import Iterable
from math import cos, sin
from typing import TYPE_CHECKING, Any, TypeVar
from typing import Any, TypeVar

import numpy as np
import pytest
Expand All @@ -22,11 +23,8 @@
OpenGLVMobject as VMobject,
)

if TYPE_CHECKING:
from collections.abc import Iterable

T1 = TypeVar("T1", Any)
T2 = TypeVar("T2", Any)
T1 = TypeVar("T1", bound=Any)
T2 = TypeVar("T2", bound=Any)


def get_add_type_error_message(
Expand Down Expand Up @@ -589,11 +587,11 @@ def test_proportion_from_point():
np.testing.assert_allclose(props, [0, 1 / 3, 2 / 3])


def test_align_points_handles_vmobject_with_no_complete_cubic_curves():
def test_align_points_handles_vmobject_with_no_complete_curves():
"""Regression test for #3569 / #4629 (fix 21cf9998 / PR #4630).

When ``align_points`` encounters a VMobject whose points array is
non-empty but holds fewer than ``n_points_per_cubic_curve`` points,
non-empty but holds fewer than ``n_points_per_curve`` points,
``get_subpaths()`` returns ``[]`` while ``has_no_points()`` returns
``False`` — so the pre-loop sanitization that would normally add a
null curve is skipped. The buggy ``get_nth_subpath`` closure then
Expand All @@ -605,19 +603,17 @@ def test_align_points_handles_vmobject_with_no_complete_cubic_curves():
broke downstream ``reshape`` calls).
"""
target = VMobject()
target.set_points(
np.array([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0], [2.0, 0.0, 0.0], [3.0, 0.0, 0.0]])
)
target.set_points(np.array([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0], [2.0, 0.0, 0.0]]))

sub_cubic = VMobject()
sub_cubic.set_points(np.array([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0], [2.0, 0.0, 0.0]]))
assert sub_cubic.get_subpaths() == []
assert sub_cubic.has_points()
sub_quadratic = VMobject()
sub_quadratic.set_points(np.array([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0]]))
assert sub_quadratic.get_subpaths() == []
assert sub_quadratic.has_points()

# Pre-fix: raises IndexError. Post-fix: completes; points are ndarray.
target.align_points(sub_cubic)
target.align_points(sub_quadratic)
assert isinstance(target.points, np.ndarray)
assert isinstance(sub_cubic.points, np.ndarray)
assert isinstance(sub_quadratic.points, np.ndarray)


def test_pointwise_become_partial_preserves_target_when_source_has_no_curves():
Expand Down