Skip to content

Fix GH actions and make concepts deterministic#2035

Merged
alistairewj merged 26 commits into
mainfrom
alistair/more_gh_action_shenanigans
Jul 8, 2026
Merged

Fix GH actions and make concepts deterministic#2035
alistairewj merged 26 commits into
mainfrom
alistair/more_gh_action_shenanigans

Conversation

@alistairewj

Copy link
Copy Markdown
Member
  • Makes concepts consistent across SQL dialects; this mostly involved removing sources of non-determinism, and caught a few bugs (biggest impact was the suspicion of infection had a non-determinism bug which made ~1% of records potentially flip - but no impact on the downstream sepsis query). Mostly these are on the order of impacting ~0.1% of rows.
    • first_day_gcs.sql, first_day_rrt.sql, oxygen_delivery.sql, suspicion_of_infection.sql
  • GH actions now orchestrated from a CI, wget with retries to avoid flakiness, cache nicely, and should all work
  • Set the postgres CI to use byte-order (C) collation to fix a very tricky non-determinism bug!
  • added a few missing concepts to postgres-make-concepts.sql
  • added indexes to postgres derived tables - sofa was taking ages to build, now just a few minutes
  • bg now uses specimen_id so we don't incorrectly aggregate over samples taken at the same charttime
  • heart rhythm now concatenates rhythms together rather than taking the alphabetical max when more than 1 is documented for a given chart time

@alistairewj alistairewj merged commit 272069d into main Jul 8, 2026
4 checks passed
@alistairewj alistairewj deleted the alistair/more_gh_action_shenanigans branch July 8, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant