chore: upgrade non-desktop builds to Vite 8 - #633
Draft
wibus-wee wants to merge 2 commits into
Draft
Conversation
Model: gpt-5
wibus-wee
added this pull request to stack #632
September 12, 2026 08:15
Model: gpt-5
Contributor
|
Desktop PR regression failed on commit
Recordings not attached
The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Same-repository dependency migration; no intake issue required.
Problem / pressure
Vite 8 replaces the build internals with Rolldown and Oxc. The independently buildable CLI, shared components, and review helper can adopt it now, while the desktop build remains constrained by
electron-vite@5's Vite 7 peer contract.Summary
apps/electronexplicitly on Vite 7.Visual explanation
Before / after
tsconfig.vite.jsoncontains only runtime-safe aliasesTest plan
pnpm install --lockfile-only --frozen-lockfile --ignore-scripts --offlinepnpm --filter @lody/code-review-helper buildpnpm --filter @lody/code-review-helper build-storybookpnpm --filter @lody/components build-storybookpnpm --filter lody dev:buildpnpm --filter lody build:bundlepnpm --dir apps/cli copy:dsh-presetspnpm --filter lody check:published-bundle-importspnpm checkpassed typecheck and lint, then reached 3,464/3,466 passing component tests under local Node 26; the two storage failures both pass under Node 22.22.0 (18/18 assertions) and are caused by Node 26's global localStorage behavior.pnpm run docs check --base deps/storybook10reports the same 12 pre-existing broken links into absent submodule files in this nested worktree.Context handoff
Instructions for reviewing agents
packages/components/tsconfig.vite.json, the two structural alias helpers, and CLI Rolldown output boundaries.vite-tsconfig-pathswith a runtime-only project is preferable to Vite's native resolver for this package.Authoring context
Original user prompt
Same-repository maintainer branch; original prompt is not required.