-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(macos): virtual HID gamepad emulating Razer Serval #5171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SayHi044
wants to merge
7
commits into
LizardByte:master
Choose a base branch
from
SayHi044:feat/macos-gamepad
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1baaf4f
feat(macos): virtual HID gamepad emulating Razer Serval
SayHi044 4b77caa
Merge branch 'master' into feat/macos-gamepad
SayHi044 9b54b80
fix(macos): resolve SonarCloud code smells and Doxygen build errors
SayHi044 c01a0ab
fix(macos): use std::thread with NOSONAR instead of std::jthread
SayHi044 a4994b8
chore(macos): tidy-up docs and comments
SayHi044 9078d5f
fix(macos): use com.apple.developer.hid.virtual.device entitlement
SayHi044 48b1fd0
Merge branch 'master' into feat/macos-gamepad
SayHi044 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry to barge on this code review.
First off thanks so much for doing this! I was so excited to be able to do this on my Tahoe M4 Mac, I built and ran this branch. Got Sunshine up and running, and then I made it to here, and realized:
A) This command ran, but did not allow for the nvram update command below, due to permission issues from io/common.
B) Realized that I was in very unsafe territory on my MacOs. I've worked in Software, and some in MacOs OS in virtualization before silicon, but I was not aware enough how quick I could break my whole computer until this didn't work.
To try to solve A, I read through bputil documentation here: https://keith.github.io/xcode-man-pages/bputil.1.html and it looked like -a may also be needed, but when I tried it still failed. I pulled back and reset full security privileges for the time being.
For B, wonder if there should be a good warning in the documentation before hand, or in the future an way to have a binary build with the developer key with a CI/CD pipeline.
Sorry if this is to much. I really want this to work and come out!