Remove unnecessary asset validation callback#1107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
AssetValidationParameters.OnNewAssetRefCallbackcallback passed toResourceValidationHelper.ValidateReference(), because after more thinking, I've determined it to be unnecessary. Any function callingValidateResource()can just simply set its asset reference toValidatedAssetResult.NewAssetRefafter calling the function without much effort. The only reason I initially implemented the callback was so we could iterate asset references using loops, but there won't really be any places where that will be useful. We won't iterate photo images after all if we want to actually implement #977, since the mainline games use TEX for small/medium images and JPEG for large images. Only place where iterating could be useful is when validating face icons, but generally, the idea of iterating the asset references (with additional data like asset type, depending on where the function is used) instead of just duplicating a few lines for simplicity is a little overcomplicated imo, and probably not worth it just for one usecase.