Fix homing bug when trying to home while homing is in progress (2.9 backport) - #4321
Open
grandixximo wants to merge 1 commit into
Open
Fix homing bug when trying to home while homing is in progress (2.9 backport)#4321grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
… in progress Fixes LinuxCNC#3314 The modification to 'command.c' prevents the homing process breaking where the joint would continue moving indefinitely. The modifications to axis.py and gmoccapy.py prevents the gui freezing that occurs due to wait_complete() timing out to the default 5 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 9d5570c (#3664) to 2.9.
Fixes #4316, which is the same bug as #3314: starting to home a second axis while a homing sequence is already in progress breaks the running homing, and the first joint keeps moving past its ref/limit switch into the mechanical limits.
The command.c change rejects EMCMOT_JOINT_HOME while homing is active, which is the machine-safety part. The axis.py and gmoccapy.py changes guard the GUIs so wait_complete() does not freeze the UI on the rejected command.
Cherry-picked cleanly onto 2.9, no conflicts.