hal: Update the remaining user component VFDs to getter/setter - #4319
Merged
Conversation
grandixximo
reviewed
Aug 2, 2026
Contributor
There was a problem hiding this comment.
I went through all four components and built the branch clean. I also ran the binaries with --help and exercised a minimal repro for the handle-vs-value cases below.
There are three places where a HAL handle is tested directly instead of the pin value. hal_bool_t is an opaque pointer into shared memory; after a successful hal_pin_new_bool it is always non-NULL, so if (!handle) is always false and if (handle) is always true, regardless of the pin state. These need hal_get_bool().
The rest looks like the expected mechanical migration. I agree with leaving the existing indentation alone; reindenting now would only pollute the blame.
grandixximo
reviewed
Aug 2, 2026
BsAtHome
force-pushed
the
halgs_vfd-user-comps
branch
from
August 2, 2026 09:25
3dc0571 to
0154223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the remaining VFD user components. They are not especially complex, but they do have many lines changed.
Unfortunately, you need to have the hardware and modbus setup to test these VFD drivers. Not something many of us have at hand. So, we need to have some eyes on the code to see if anything got missed.
Note, a lot of the content is badly indented. A few places were corrected (like parts of the hal structs), but most of it needs to be done another time. Altering too much will just confuse the blame and make tracking any potential problems hard. So, mostly left as is.