Proof: laned semantic verification assembly (V5b2d-2a) - #534
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughДобавлена сборка semantic verification из lane-фрагментов. ChangesСемантическая верификация по lane-фрагментам
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant WindowLaneArtifactV1
participant assemble_semantic_verification_v1
participant corpus_assembly
participant verify_transcript
participant SemanticVerificationReceiptV1
WindowLaneArtifactV1->>assemble_semantic_verification_v1: передача lane-фрагментов
assemble_semantic_verification_v1->>corpus_assembly: сборка DecisionTranscriptV1
corpus_assembly-->>assemble_semantic_verification_v1: собранный transcript
assemble_semantic_verification_v1->>verify_transcript: семантическая проверка
verify_transcript-->>assemble_semantic_verification_v1: receipt или rejection
assemble_semantic_verification_v1->>SemanticVerificationReceiptV1: sealing успешного результата
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@proof/region/v1/verification_assembly.py`:
- Around line 57-63: Update the lane normalization in
assemble_semantic_verification_v1 to catch Exception, not only TypeError, so
iterator failures such as ValueError and RuntimeError are converted into _reject
with SemanticVerificationReasonV1.INVALID_INPUT and the fixed existing message.
Add a test using an iterator whose __iter__ or __next__ raises one of these
exceptions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4a3db773-7120-4acc-8251-0d6302b43984
📒 Files selected for processing (4)
proof/region/v1/semantic/__init__.pyproof/region/v1/semantic/verifier.pyproof/region/v1/tests/test_verification_assembly.pyproof/region/v1/verification_assembly.py
1 participant
Summary
SemanticVerificationReceiptV1can never come from one sequential replay of 2^24 points, so the independent replay now runs as the same packing-aligned window lanes the full-domain RUN uses and assembly seals the one receipt from a complete lane cover.verification_assembly.assemble_semantic_verification_v1admits lanes through the existing corpus lane admission, reassembles the monolithic transcript via the existing shard assembly, and seals exactly when the reassembled independent replay is byte-identical to the verified transcript; gaps, overlaps, reorders, drift and foreign bindings are typed rejections.semantic.verifier.bind_transcript_v1is extracted as the single binding surface shared by the monolithic verifier and the laned path (behaviour identical, hostile suites green).This is the next V5b2d DAG node toward
DualProofReceiptV1(full_domain=True): reduced-domain contracts stay untouched, the receipt type and sealing path are unchanged, and no engine or controller code is imported.Test plan
py -m unittest tests.test_verification_assembly— 8/8 (RED first: module absent)test_semantic_receipt, replay/diversity/folding/intervalmath) greentest_corpus_assembly,test_corpus_lanes) greentest_full_domain_gategreen; pinned gatesverify_point_support_surplus.pyandverify_clean_set_receipt.py productgreen (no Rust touched)Summary by CodeRabbit
Новые возможности
Исправления