Tone down warnings about unknown directories in package - #481
Merged
Conversation
pehrsoderman
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simonlindholm @Tagl @Matistjati thanks for the quick feedback in #479
This PR tweaks the rules, and should make this much less spammy. We now only warn for relatively close typos (and, of course, known renames and directories from other versions). We also do not check edit distance to directories which exist. So, for instance, if you only have
old-submissions, we will give you a warning about that being a potential typo, but if the package also hassubmissions, thenold_submissionsgenerates no warning.I think/hope this is enough to help less experienced problem setters to quickly catch incorrect directories (and for everyone to catch
attachment), without getting in the way.