Extract submissions model - #471
Merged
Merged
Conversation
…ith them in another way.
Contributor
Author
|
Lol, I was using the bad example in different to verify that the checks now flagged it as an error. Forgot to remove it in the PR. Now this removes the example submission in different in a directory which does not match the spec ( |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
pehrsoderman
approved these changes
Aug 26, 2026
meisterT
added a commit
to meisterT/domjudge
that referenced
this pull request
Aug 29, 2026
The bad file has been deleted as part of Kattis/problemtools#471
meisterT
added a commit
to DOMjudge/domjudge
that referenced
this pull request
Aug 30, 2026
The bad file has been deleted as part of Kattis/problemtools#471 (cherry picked from commit dadc81f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting the next part of verifyproblem - submissions into model + checks. Adds some very mild plumbing in the form of a
LegacyPolicy(should perhaps be renamed to something with "expectations" as that seems to have been the working name for what became submissions.yaml), where the idea is to eventually adjust the interface to be able to represent submissions.yaml.I think the check code for submissions can be rewritten a bit (e.g., utilizing the policy in a better way), but I intentionally kept it as close as possible while lifting it out of verifyproblem to at least somewhat facilitate reviewing (though, lifting out large code blocks with some changes is not very conductive to reviewing).
Progress on #398