-
Notifications
You must be signed in to change notification settings - Fork 16
Display ROI #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Display ROI #40
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| @enum AlignOptions begin | ||
| top_left = 1 | ||
| top_right = 2 | ||
| bottom_right = 3 | ||
| bottom_left = 4 | ||
| end | ||
|
|
||
| function inset_roi( | ||
| img::AbstractArray{T, 2}, | ||
| roi::NTuple{2, NTuple{2, <:Int}}, | ||
| scale::R, | ||
| align::AlignOptions, | ||
| color::C | ||
| ) where {T<:Colorant, R<:Real, C<:Colorant} | ||
|
Comment on lines
+8
to
+15
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If This won't be a big issue as people are using it in a try-and-see manner. It would be more convenient to make
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed this |
||
|
|
||
| ((sx, sy), (ex, ey)) = roi | ||
|
|
||
| if !checkindex(Bool, axes(img, 1), sx) || | ||
| !checkindex(Bool, axes(img, 1), ex) || | ||
| !checkindex(Bool, axes(img, 2), sy) || | ||
| !checkindex(Bool, axes(img, 2), ey) | ||
| throw(ArgumentError("Region of interest lies out of image")) | ||
| end | ||
|
Comment on lines
+17
to
+41
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
R = CartesianIndices(img)
roi = CartesianIndices(roi)
I_first, I_last = first(roi), last(roi)
(I_first in R && I_last in R) || throw(ArgumentError("Region of interest lies out of image"))We don't need to check |
||
|
|
||
| U = promote_type(T, C) # support different types natively | ||
| img = convert.(U, img) # copy | ||
| color = convert(U, color) | ||
|
|
||
| roi_image = @view img[sx:ex, sy:ey] | ||
| roi_image = imresize(roi_image; ratio=scale) # copy | ||
|
|
||
| if !all(size(roi_image) .<= size(img)) | ||
| throw(ArgumentError("The scaled region of interest is larger than the image")) | ||
| end | ||
|
|
||
| border_rect = [ | ||
| (first(axes(roi_image, 2)), first(axes(roi_image, 1))), | ||
| (last(axes(roi_image, 2)), first(axes(roi_image, 1))), | ||
| (last(axes(roi_image, 2)), last(axes(roi_image, 1))), | ||
| (first(axes(roi_image, 2)), last(axes(roi_image, 1))), | ||
| ] | ||
|
|
||
| draw!(roi_image, Polygon(border_rect), color) | ||
|
|
||
| roi_rect = [ | ||
| (sy, sx), | ||
| (ey, sx), | ||
| (ey, ex), | ||
| (sy, ex) | ||
| ] | ||
| draw!(img, Polygon(roi_rect), color) | ||
|
|
||
| if align == top_left | ||
| img[first(axes(img, 1)):first(axes(img, 1))+size(roi_image, 1)-1, | ||
| first(axes(img, 2)):first(axes(img, 2))+size(roi_image, 2)-1] = roi_image | ||
| elseif align == top_right | ||
| img[first(axes(img, 1)):first(axes(img, 1))+size(roi_image, 1)-1, | ||
| last(axes(img, 2))-size(roi_image, 2)+1:last(axes(img, 2))] = roi_image | ||
| elseif align == bottom_right | ||
| img[last(axes(img, 1))-size(roi_image, 1)+1:last(axes(img, 1)), | ||
| last(axes(img, 2))-size(roi_image, 2)+1:last(axes(img, 2))] = roi_image | ||
| else | ||
| align == bottom_left | ||
| img[last(axes(img, 1))-size(roi_image, 1)+1:last(axes(img, 1)), | ||
| first(axes(img, 2)):first(axes(img, 2))+size(roi_image, 2)-1] = roi_image | ||
| end | ||
|
|
||
| return img | ||
| end | ||
|
|
||
| function display_roi( | ||
| img::AbstractArray{T, 2}, | ||
| roi::AbstractVector{NTuple{2, NTuple{2, <:Int}}}, | ||
| size::AbstractVector{<:Real}, | ||
| align::AbstractVector{AlignOptions}, | ||
| color::AbstractVector{C} | ||
| ) where {T<:Colorant, C<:Colorant} | ||
| if !(length(roi) == length(size) == length(color) == length(align)) | ||
| throw(ArgumentError("Arrays roi, size, align and color must be of the same length, instead got $(length(roi)), $(length(size)), $(length(align)) and $(length(color))")) | ||
| end | ||
|
|
||
| if length(roi) > 4 | ||
| throw(ArgumentError("Only upto 4 regions of interest can be displayed, instead got $(length(roi))")) | ||
| end | ||
|
|
||
| if length(unique(align)) < length(align) | ||
| @warn "Similarly aligned regions will likely overlap" | ||
| end | ||
|
|
||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to ensure
scaleis positiveThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!