[19.0][MIG] storage_backend_sftp: Migration to 19.0 - #3
Open
alan196 wants to merge 9 commits into
Open
Conversation
A way to classify storages in a functional way. For instance: you might have N storage backends for the shop, N storage backends for data import, N storage backends for EDI purposes. With this change you can finally organize them and let your customers understand what such storages do.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-18.0/storage-18.0-storage_backend Translate-URL: https://translation.odoo-community.org/projects/storage-18-0/storage-18-0-storage_backend/
Currently translated at 100.0% (28 of 28 strings) Translation: storage-18.0/storage-18.0-storage_backend Translate-URL: https://translation.odoo-community.org/projects/storage-18-0/storage-18-0-storage_backend/it/
(cherry picked from commit 28e6c0f)
… get and add (cherry picked from commit 0c925fd)
…er-using-with) Required by Jarsa pre-commit-vauxoo mandatory checks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Available types: 'task#', 't#' (case insensitive) Examples:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
storage_backend_sftpto 19.0.Stacked on PR #2 (
[19.0][MIG] storage_backend: Migration to 19.0) — this branch is based on19.0-mig-storage_backendand includes its commit. Merge #2 first; after that, this PR will only show the sftp commits.Commits on top of #2:
[MIG] storage_backend_sftp: Migration to 19.0— cherry-picked from OCA PR [MIG] storage_backend_sftp: Migration to 19.0 OCA/storage#644 (author @AungKoKoLin1997 / Quartile): makes the module installable again (19.0.1.0.0), movesparamikoto a plain import, adds it torequirements.txtand fixes themove_filestest.[FIX] storage_backend_sftp: ensure the conection is closed when move, get and add— forward-port of the Jarsa 17.0 fix (0c925fd): robustsftp()context manager (try/finally closing client and transport) andwithblocks for remote file handles.[REF] storage_backend_sftp: Fix pylint checks— no-else-return and consider-using-with fixes required by pre-commit-vauxoo mandatory checks.Tested:
pre-commit-vauxoo -p storage_backend_sftpMandatory/Optional = Passed; install + tests on a scratch 19.0 DB: 7 tests, 0 failed, 0 error (all tests mock paramiko, no real SFTP server required).Note for reviewers: the Jarsa 17.0 commit
[IMP] storage_backend: add active field to view(1e074f2) is NOT included in the storage_backend 19.0 migration (PR #2) — theactivefield no longer exists onstorage.backendin the 18.0-based code. Review whether it must be re-added in #2.🤖 Generated with Claude Code