Move build system to meson-python#174
Open
ndgrigorian wants to merge 15 commits into
Open
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
force-pushed
the
use-meson-build
branch
4 times, most recently
from
1f7006a to
e209e46
Compare
ndgrigorian
force-pushed
the
use-meson-build
branch
from
e209e46 to
dfc8f4c
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates mkl-service from a setuptools/setup.py-driven build to a meson-python build, updating conda recipes and CI workflows accordingly, and adding an mkl runtime dependency.
Changes:
- Remove
setup.pyand define extension builds/install layout inmeson.build(C + Cython extensions, Python sources, tests). - Switch
pyproject.tomlbuild backend tomesonpyand addmklto runtime dependencies. - Update conda recipes and GitHub Actions workflows to build/install via
pip/python -m buildinstead ofsetup.py.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setuptools build script. |
| pyproject.toml | Switched build backend to mesonpy, updated build requirements and runtime deps. |
| meson.build | Added Meson build definition for C/Cython extensions and installation layout. |
| mkl/_py_mkl_service.pyx | Added/introduced Cython wrapper implementation used by the public API. |
| conda-recipe/meta.yaml | Updated conda build requirements for Meson-based builds. |
| conda-recipe/build.sh | Updated wheel build/install flow (no setup.py). |
| conda-recipe/bld.bat | Removed setup.py clean step and MKLROOT usage. |
| conda-recipe-cf/meta.yaml | Updated conda-forge recipe host requirements for Meson-based builds. |
| conda-recipe-cf/build.sh | Switched to pip install . build/install flow. |
| conda-recipe-cf/bld.bat | Switched to pip install . build/install flow. |
| .github/workflows/build-with-standard-clang.yml | New CI job building with system clang. |
| .github/workflows/build-with-clang.yml | Updated IntelLLVM clang CI job to Meson-based install. |
| .github/workflows/build_pip.yml | New CI job testing editable install + (pre-)release NumPy in conda env. |
| 'mkl-service', | ||
| ['c', 'cython'], | ||
| version: run_command( | ||
| 'python', '-c', |
There was a problem hiding this comment.
run_command('python', ...) hardcodes the interpreter, which may not match Meson’s discovered Python (virtualenv/pyenv/Windows). Use the py installation found by import('python').find_installation() when computing the version to avoid mismatched interpreters.
Suggested change
| 'python', '-c', | |
| import('python').find_installation(pure: false), '-c', |
Collaborator
There was a problem hiding this comment.
It sounds reasonable, NumPy implements the same:
run_command(py, ['-c', 'import os; exec(open("mkl/_version.py").read()); print(__version__)'], check: true).stdout().strip()
| strategy: | ||
| matrix: | ||
| python: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| numpy_version: ["numpy'>=2'"] |
There was a problem hiding this comment.
The matrix value numpy_version: ["numpy'>=2'"] includes embedded quotes and will be passed verbatim to pip install, which is not a valid requirement specifier. Use something like numpy>=2 (or just install numpy and control pre-releases separately).
Suggested change
| numpy_version: ["numpy'>=2'"] | |
| numpy_version: ["numpy>=2"] |
| strategy: | ||
| matrix: | ||
| python: ["3.10", "3.11", "3.12", "3.13"] | ||
| numpy_version: ["numpy'>=2'"] |
There was a problem hiding this comment.
The matrix value numpy_version: ["numpy'>=2'"] includes embedded quotes and will be passed verbatim to pip install, which is not a valid requirement specifier. Use something like numpy>=2.
Suggested change
| numpy_version: ["numpy'>=2'"] | |
| numpy_version: ["numpy>=2"] |
ndgrigorian
force-pushed
the
use-meson-build
branch
3 times, most recently
from
b3cd7c9 to
3fb7aff
Compare
antonwolfy
reviewed
Apr 24, 2026
antonwolfy
reviewed
Apr 24, 2026
antonwolfy
reviewed
Apr 24, 2026
antonwolfy
reviewed
Apr 24, 2026
antonwolfy
reviewed
Apr 24, 2026
antonwolfy
reviewed
Apr 24, 2026
ndgrigorian
force-pushed
the
use-meson-build
branch
from
ef09add to
ac6e9fc
Compare
add build instructions
remove unnecessary packages and add python 3.14 to clang build
ndgrigorian
force-pushed
the
use-meson-build
branch
from
ac6e9fc to
b39b64b
Compare
antonwolfy
reviewed
Jun 24, 2026
antonwolfy
reviewed
Jul 9, 2026
|
|
||
| permissions: read-all | ||
|
|
||
| env: |
Collaborator
There was a problem hiding this comment.
The env block is unused
| @@ -37,7 +37,7 @@ Higher-precedence file overrides; lower must not restate overridden guidance. | |||
| - Build/config: `pyproject.toml`, `setup.py` | |||
Collaborator
There was a problem hiding this comment.
Still listing setup.py
Suggested change
| - Build/config: `pyproject.toml`, `setup.py` | |
| - Build/config: `pyproject.toml`, `meson.build` |
| - **Docs:** MKL support functions documented in [Intel oneMKL Developer Reference](https://www.intel.com/content/www/us/en/docs/onemkl/developer-reference-c/2025-2/support-functions.html) | ||
|
|
||
| ## Code structure | ||
| - **Cython layer:** `_mkl_service.pyx` + `_mkl_service.pxd` (C declarations) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - **Cython layer:** `_py_mkl_service.pyx` + `_mkl_service.pxd` (C declarations) |
| - **Python versions:** 3.10, 3.11, 3.12, 3.13, 3.14 | ||
| - **Workflows:** `.github/workflows/` | ||
| - `conda-package.yml` — main conda build/test pipeline | ||
| - `conda-package-cf.yml — conda build/test using only conda-forge channel |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `conda-package-cf.yml — conda build/test using only conda-forge channel | |
| - `conda-package-cf.yml` — conda build/test using only conda-forge channel |
| - `conda-package-cf.yml — conda build/test using only conda-forge channel | ||
| - `build-with-clang.yml` — Linux Clang compatibility | ||
| - `build-with-standard-clang.yml` — standard Clang compiler compatibility validation | ||
| - `build_pip` — validates editable build |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `build_pip` — validates editable build | |
| - `build_pip.yml` — validates editable build |
| number: {{ GIT_DESCRIBE_NUMBER }} | ||
| skip: true # [osx and arm64] | ||
| script_env: | ||
| - WHEELS_OUTPUT_FOLDER |
Collaborator
There was a problem hiding this comment.
WHEELS_OUTPUT_FOLDER is not used with conda-forge
| - {{ stdlib('c') }} | ||
| host: | ||
| - meson-python >=0.13.0 | ||
| - meson |
Collaborator
There was a problem hiding this comment.
meson-python already cover that:
Suggested change
| - meson |
| - {{ stdlib('c') }} | ||
| host: | ||
| - meson-python >=0.13.0 | ||
| - meson |
Collaborator
There was a problem hiding this comment.
the same
Suggested change
| - meson |
| 'import os; exec(open("mkl/_version.py").read()); print(__version__)', | ||
| check: true | ||
| ).stdout().strip(), | ||
| default_options: [ |
Collaborator
There was a problem hiding this comment.
Should we floor the meson version (used in NumPy)?
Suggested change
| default_options: [ | |
| meson_version: '>=1.8.3', | |
| default_options: [ |
| 'mkl-service', | ||
| ['c', 'cython'], | ||
| version: run_command( | ||
| 'python', '-c', |
Collaborator
There was a problem hiding this comment.
It sounds reasonable, NumPy implements the same:
run_command(py, ['-c', 'import os; exec(open("mkl/_version.py").read()); print(__version__)'], check: true).stdout().strip()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from
setuptoolstomeson-pythonas themkl-servicebuild systemmeson-pythonis already used by NumPy and allowssetup.pyto be removed (with its logic moved into themeson.buildscript)