Add optional MySQL player data storage - #46
Open
PGS-hwan wants to merge 1 commit into
Open
Conversation
- Add MySQL storage - Load and save player tag data asynchronously - Fall back to YAML if MySQL initialization fails - Preserve existing YAML behavior and `load_tag_on_join` support - Try to fix compatibility for legacy Bukkit versions such as Paper 1.8.8 Existing `player_tags.yml` data is not automatically migrated
Member
|
Ideally a PR focuses on 1 thing, "Try to fix compatibility for legacy Bukkit versions such as Paper 1.8.8" should be split out |
Author
I fixed it because the code wasn't working on older versions, as I considered it a critical issue. I'll be more careful in my next commit, as this was my first pull request :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_tag_on_joinsupportExisting
player_tags.ymldata is not automatically migrated