Add func check tests 2#18376
Open
vr-ibm wants to merge 4 commits into
Open
Conversation
modular-magician
added
awaiting-approval
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1a9c21d: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
vr-ibm
marked this pull request as ready for review
July 23, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is Part 3 of the
template-check func-checkseries. This PR adds validation for advanced Go template syntax and ensures error reporting accuracy.Changes:
TestFuncCheck_Pipelines: Verifies that functions used within pipelines (e.g.,{{ .Name | camelize }}) are correctly identified and validated.TestFuncCheck_LineNumbers: Verifies that the linter accurately reports the line number of invalid functions, ensuring developers can quickly locate errors in large.go.tmplfiles.Note: This PR is based on
add-func-check-tests-1. It should be merged after Part 2.Release Note Template for Downstream PRs (will be copied)