Skip to content

compute: support alphanumeric build names in fedoraImage diff suppress regex [advanced]#18375

Open
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-compute-disk-fedora-image-diff-suppress-28424
Open

compute: support alphanumeric build names in fedoraImage diff suppress regex [advanced]#18375
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-compute-disk-fedora-image-diff-suppress-28424

Conversation

@shuyama1

Copy link
Copy Markdown
Member

Resolves acceptance test failure TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames.

The regular expression fedoraImage previously only matched numeric digits ([0-9]+) for the 4th version component of Fedora CoreOS image names. Newer Fedora CoreOS images (e.g. fedora-coreos-43-20260411-20-dev0-gcp-aarch64) include alphanumeric build tags (e.g. dev0). This update allows fedoraImage to match alphanumeric build tags.

Fixes hashicorp/terraform-provider-google#28424

compute: fixed image diff suppression for Fedora CoreOS images with alphanumeric build tags

@shuyama1 shuyama1 changed the title compute: support alphanumeric build names in fedoraImage diff suppress regex compute: support alphanumeric build names in fedoraImage diff suppress regex [advanced] Jul 23, 2026
@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6571259:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 6 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 6 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1454 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shuyama1 VCR tests complete for 6571259!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames

2 participants