fix: apigee_flowhook continue_on_error argument#18374
Conversation
- The continue_on_error arguement is being dropped if it is set to false so there is no way to set the variable to false - If you set it, it will show up in the plan then you apply it will apply but the change won't persist, so the next plan will try to change it again.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bb179a7: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccApigeeFlowhook_continueOnErrorFalse Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @ShuguBota, @BBBmau VCR tests complete for bb179a7! |
Description
The
continue_on_errorarguement is being dropped if it is set tofalseso there is no way to set the variable tofalse.Problem
If you set
continue_on_errorarguement tofalseit will show up in the plan properly. You apply it will apply, it will say everything got applied but the change will not persist. Running the plan again will try to set it again. In GCP it never changes from true which is the default by which gets created with becausecontinue_on_erroris an optional flag which by default is true.Solution
This change fixes the handling of
continue_on_errorby checking whether the attribute was explicitly configured in the Terraform configuration instead of treatingfalseas an empty value, ensuring that bothtrueandfalseare correctly sent to the Apigee API.Testing
continue_on_error = falsecase.continue_on_errorso bothtrueandfalseconfigurations can be exercised.testAccCheckApigeeFlowhookContinueOnError) that performs a direct GET request against the Apigee API and asserts that the returnedcontinueOnErrorvalue matches the expected boolean.