Skip to content

fix: apigee_flowhook continue_on_error argument#18374

Open
ShuguBota wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ShuguBota:fix/apigee-flowhook
Open

fix: apigee_flowhook continue_on_error argument#18374
ShuguBota wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ShuguBota:fix/apigee-flowhook

Conversation

@ShuguBota

@ShuguBota ShuguBota commented Jul 23, 2026

Copy link
Copy Markdown

Description

The continue_on_error arguement is being dropped if it is set to false so there is no way to set the variable to false.

apigee: fixed `continue_on_error` arguement being dropped in `google_apigee_flowhook`, aligning provider behavior with the Apigee API

Problem

If you set continue_on_error arguement to false it will show up in the plan properly. You apply it will apply, it will say everything got applied but the change will not persist. Running the plan again will try to set it again. In GCP it never changes from true which is the default by which gets created with because continue_on_error is an optional flag which by default is true.

Solution

This change fixes the handling of continue_on_error by checking whether the attribute was explicitly configured in the Terraform configuration instead of treating false as an empty value, ensuring that both true and false are correctly sent to the Apigee API.

Testing

  • Added an acceptance test covering the continue_on_error = false case.
  • Updated the existing acceptance test to parameterize continue_on_error so both true and false configurations can be exercised.
  • Added an API verification helper (testAccCheckApigeeFlowhookContinueOnError) that performs a direct GET request against the Apigee API and asserts that the returned continueOnError value matches the expected boolean.
  • Verified that both resource creation and import correctly preserve the configured value.

- The continue_on_error arguement is being dropped if it is set to false so there is no way to set the variable to false
- If you set it, it will show up in the plan then you apply it will apply but the change won't persist, so the next plan will try to change it again.
@google-cla

google-cla Bot commented Jul 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 23, 2026
@github-actions
github-actions Bot requested a review from BBBmau July 23, 2026 21:40
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/apigee and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 23, 2026
@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bb179a7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 87 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 87 insertions(+), 5 deletions(-)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccApigeeFlowhook_continueOnErrorFalse

Analytics

Total Tests Passed Skipped Affected
84 40 44 0
Affected Service Packages
  • apigee

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@ShuguBota, @BBBmau VCR tests complete for bb179a7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants