tools/template-check: add func-check subcommand and core logic#18371
Open
vr-ibm wants to merge 1 commit into
Open
tools/template-check: add func-check subcommand and core logic#18371vr-ibm wants to merge 1 commit into
vr-ibm wants to merge 1 commit into
Conversation
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4903a25: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
vr-ibm
marked this pull request as ready for review
July 23, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is Part 1 of a stacked PR series to introduce a template function validator. This PR adds the core regex engine and the CLI subcommand.
Currently, using an invalid function (like
BigQueryBasePathin a handwritten.go.tmplfile) only surfaces as a compilation error after ~20 minutes of CI. This linter catches those errors in <1s by validating against all registeredmmv1template functions.Changes:
gotemplate.CheckInvalidFuncsForFilelogic to scan.tmplfiles for unknown functions.template-check func-checksubcommand to the CLI for local development.Note: To keep the review manageable (<250 lines), the comprehensive test suite and CI integration will follow in subsequent PRs.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.