Skip to content

Feature branch major release 8.0.0 main sync july 23#18370

Open
BBBmau wants to merge 30 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
BBBmau:FEATURE-BRANCH-major-release-8.0.0-main-sync-july-23
Open

Feature branch major release 8.0.0 main sync july 23#18370
BBBmau wants to merge 30 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
BBBmau:FEATURE-BRANCH-major-release-8.0.0-main-sync-july-23

Conversation

@BBBmau

@BBBmau BBBmau commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


BBBmau and others added 30 commits July 17, 2026 17:18
…tform#18154)

Co-authored-by: Cameron Thornton <camthornton@google.com>
…ckend service (GoogleCloudPlatform#18293)

Signed-off-by: Ming Zhou <zhouming@google.com>
…source to use direct HTTP rather then a client library (GoogleCloudPlatform#18138)

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
GoogleCloudPlatform#17765)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/terraform and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 23, 2026
@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d21e988:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 88 files changed, 15532 insertions(+), 583 deletions(-)
google-beta provider View Diff 85 files changed, 14967 insertions(+), 543 deletions(-)
terraform-google-conversion View Diff 31 files changed, 4035 insertions(+), 43 deletions(-)
Open in Cloud Shell View Diff 34 files changed, 1266 insertions(+), 1 deletion(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field secret_data_wo within resource google_secret_manager_secret_version was added to exactly one of - reference
  • Field secret_data within resource google_secret_manager_secret_version was added to exactly one of - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_schedule (16 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_schedule" "primary" {
  create_notebook_execution_job_request {
    notebook_execution_job {
      custom_environment_spec {
        machine_spec {
          reservation_affinity {
            key                       = # value needed
            reservation_affinity_type = # value needed
            use_reservation_pool      = # value needed
            values                    = # value needed
          }
        }
      }
    }
  }
}

Resource: google_vector_search_data_object (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vector_search_data_object" "primary" {
  etag = # value needed
}

Resource: google_vertex_ai_endpoint_with_model_garden_deployment (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_with_model_garden_deployment" "primary" {
  deploy_config {
    dedicated_resources {
      autoscaling_metric_specs {
        metric_name = # value needed
        target      = # value needed
      }
      required_replica_count = # value needed
    }
  }
}

Resource: google_vertex_ai_persistent_resource (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_persistent_resource" "primary" {
  resource_pools {
    machine_spec {
      accelerator_count = # value needed
      accelerator_type  = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_persistent_resource

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_chronicle_big_query_export, google_cloud_quotas_quota_adjuster_settings, google_vector_search_data_object, google_vertex_ai_persistent_resource. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_composer_environment
    • Expected Document Path: /website/docs/r/composer_environment.html.markdown
    • Fields: [config.node_config.traffic_routing_config config.node_config.traffic_routing_config.cloud_run_functions_routing]

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccSecretManagerSecretVersion_neitherSecretDataSet
🔴 TestAccVertexAIEndpointWithModelGardenDeployment_machineTypeStillForcesReplacement
🔴 TestAccVertexAIEndpointWithModelGardenDeployment_updateReplicaCountInPlace

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccCloudQuotasQuotaAdjusterSettings_cloudQuotasQuotaAdjusterSettingsUpdate
🔴 TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate
🔴 TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate

Analytics

Total Tests Passed Skipped Affected
2745 2460 268 17
Affected Service Packages
  • cloudquotas
  • cloudrunv2
  • colab
  • resourcemanager
  • gkehub2
  • vectorsearch
  • bigtable
  • composer
  • compute
  • developerconnect
  • modelarmor
  • osconfigv2
  • secretmanager
  • sql
  • chronicle
  • container
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withNodeImageConfig
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccProjectIamPolicy_invalidMembers
  • TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject
  • TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections
  • TestAccSqlDatabaseInstance_withPSCEnabled_withAutoConnectionPolicy
  • TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects
  • TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled
  • TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections
  • TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects
  • TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections
  • TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUriOnCreate
  • TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerNodePool_withNodeImageConfig
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log TestAccProjectIamPolicy_invalidMembers
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections
✅ Log TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUriOnCreate
✅ Log TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccSqlDatabaseInstance_withPSCEnabled_withAutoConnectionPolicy

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for d21e988!

@BBBmau
BBBmau requested a review from melinath July 23, 2026 22:17
@melinath
melinath requested review from c2thorn and removed request for melinath July 23, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.