Feature branch major release 8.0.0 main sync july 23#18370
Conversation
…udPlatform#18016) Co-authored-by: Mateusz Pielat <mpielat@google.com>
…tform#18154) Co-authored-by: Cameron Thornton <camthornton@google.com>
…x_ai_schedule as deprecated (GoogleCloudPlatform#18303)
…ckend service (GoogleCloudPlatform#18293) Signed-off-by: Ming Zhou <zhouming@google.com>
…source to use direct HTTP rather then a client library (GoogleCloudPlatform#18138) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
GoogleCloudPlatform#17765) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d21e988: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_colab_schedule" "primary" {
create_notebook_execution_job_request {
notebook_execution_job {
custom_environment_spec {
machine_spec {
reservation_affinity {
key = # value needed
reservation_affinity_type = # value needed
use_reservation_pool = # value needed
values = # value needed
}
}
}
}
}
}
Resource: resource "google_vector_search_data_object" "primary" {
etag = # value needed
}
Resource: resource "google_vertex_ai_endpoint_with_model_garden_deployment" "primary" {
deploy_config {
dedicated_resources {
autoscaling_metric_specs {
metric_name = # value needed
target = # value needed
}
required_replica_count = # value needed
}
}
}
Resource: resource "google_vertex_ai_persistent_resource" "primary" {
resource_pools {
machine_spec {
accelerator_count = # value needed
accelerator_type = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccSecretManagerSecretVersion_neitherSecretDataSet Important Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccCloudQuotasQuotaAdjusterSettings_cloudQuotasQuotaAdjusterSettingsUpdate Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.