Skip to content

compute: fix DiskImageDiffSuppress for fedora-coreos testing-devel images [default]#18369

Open
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:issue-28424-fix
Open

compute: fix DiskImageDiffSuppress for fedora-coreos testing-devel images [default]#18369
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:issue-28424-fix

Conversation

@shuyama1

Copy link
Copy Markdown
Member

Update fedoraImage regex to support non-numeric sub-build components (such as dev0) in Fedora CoreOS testing-devel stream images.

Fixes hashicorp/terraform-provider-google#28424

compute: fixed diff suppression for `google_compute_disk` when referencing Fedora CoreOS images with `dev` sub-builds

@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d6e73dc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 11 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 11 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1454 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shuyama1 VCR tests complete for d6e73dc!

@shuyama1 shuyama1 changed the title compute: fix DiskImageDiffSuppress for fedora-coreos testing-devel images compute: fix DiskImageDiffSuppress for fedora-coreos testing-devel images [default] Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames

2 participants