Add support for scheduleCustomizations in the rule deployment resource.#18364
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1da9c0c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @ankitgoyal0301 VCR tests complete for 1da9c0c! |
Add
schedule_customizationsfield toRuleDeploymentresource.This is for the customizable schedules feature, which is launching to GA soon. In addition to the typical boilerplate of adding a new field, we had to add special logic to the custom_create and pre_update handlers to address two problems:
Added test cases to catch these edge cases.
I also removed the logic that removes runFrequency from the updateMask. This is no longer needed because we made run frequency updates idempotent in Feb 2026.
IMPORTANT: We have to take action to prevent this PR from breaking the CI pipeline. There is a customer feature flag called "customizable_rule_reruns_enabled". When that flag is off, these tests will not pass, because you can't use scheduleCustomizations w/o that flag on. But when that flag is on, the current tests will not pass, because when the flag is on you can't change a single-event rule (the current test case) from LIVE -> DAILY. So we need to submit this PR + flip the feature flag in quick succession or else the daily pipeline will break.
Release Note Template for Downstream PRs (will be copied)