Skip to content

networkconnectivity: fix hub-only google_network_connectivity_transport (exactly one of hub/network)#18362

Open
AzySir wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
AzySir:fix/issue-28425-hub-parameter
Open

networkconnectivity: fix hub-only google_network_connectivity_transport (exactly one of hub/network)#18362
AzySir wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
AzySir:fix/issue-28425-hub-parameter

Conversation

@AzySir

@AzySir AzySir commented Jul 22, 2026

Copy link
Copy Markdown

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Description

google_network_connectivity_transport treated network as required, so NCC hub-only configs failed provider validation even though the API allows either network or hub.

This change:

  • removes required: true from network
  • adds exactly_one_of: [hub, network] on both fields
  • updates field descriptions
  • adds a unit test that asserts the schema shape

Fixes hashicorp/terraform-provider-google#28425

Testing

  • Generated beta provider for networkconnectivity / Transport
  • Unit test: TestUnitNetworkConnectivityTransport_networkHubExactlyOneOf (PASS)
networkconnectivity: fixed `google_network_connectivity_transport` incorrectly requiring `network` when `hub` is set; exactly one of `network` or `hub` is required (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 22, 2026
@google-cla

google-cla Bot commented Jul 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
github-actions Bot requested a review from SirGitsalot July 22, 2026 22:07
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@AzySir

AzySir commented Jul 24, 2026

Copy link
Copy Markdown
Author

@SirGitsalot hope you're well - can we get a review on this one please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_network_connectivity_transport failing on NCC mode

2 participants