Skip to content

Make Organization field in subjectConfig optional when creating certs#18353

Merged
shuyama1 merged 6 commits into
GoogleCloudPlatform:mainfrom
rohanchawla23:cas-cert-org-optional
Jul 24, 2026
Merged

Make Organization field in subjectConfig optional when creating certs#18353
shuyama1 merged 6 commits into
GoogleCloudPlatform:mainfrom
rohanchawla23:cas-cert-org-optional

Conversation

@rohanchawla23

@rohanchawla23 rohanchawla23 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Previously it was required to specify the organization name when using an x509 subject config to create a Certificate. This requirement is not enforced anywhere else in our service (including gcloud and UI) so it is being removed from the Terraform surface to allow for more flexible use cases.

I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one sample (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

privateca: made `config.subject_config.subject.organization` optional in `google_privateca_certificate`

rohanchawla23 and others added 3 commits July 21, 2026 17:11
Remove requirement to specify organization when providing an x509
subject when creating a certificate.
Added a test to confirm a certificate can be created without
specifying an organization in the subject field.
@modular-magician

modular-magician commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1680b73:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
google-beta provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 3 files changed, 12 insertions(+), 10 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
46 37 8 1
Affected Service Packages
  • privateca

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccPrivatecaCertificate_privatecaCertificateNoOrgExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccPrivatecaCertificate_privatecaCertificateNoOrgExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@rohanchawla23 VCR tests complete for 1680b73!

@modular-magician

modular-magician commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 15ed47d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
google-beta provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 3 files changed, 12 insertions(+), 10 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
46 38 8 0
Affected Service Packages
  • privateca

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@rohanchawla23 VCR tests complete for 15ed47d!

@rohanchawla23

Copy link
Copy Markdown
Contributor Author

terraform-google-conversion-test-integration failure can be ignored. Failing due to issues in other services (container, secretmanager, workbench, dataplex, compute). All privateca tests pass.

Comment thread mmv1/products/privateca/Certificate.yaml Outdated
@sophyawu09

Copy link
Copy Markdown
Contributor

Otherwise, LGTM!

Changed test name to more exactly describe what its testing.
@modular-magician

modular-magician commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7210d00:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
google-beta provider View Diff 3 files changed, 213 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 3 files changed, 12 insertions(+), 10 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
46 37 8 1
Affected Service Packages
  • privateca

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccPrivatecaCertificate_privatecaCertificateSubjectConfigOrgOptionalExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccPrivatecaCertificate_privatecaCertificateSubjectConfigOrgOptionalExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@rohanchawla23 VCR tests complete for 7210d00!

@rohanchawla23
rohanchawla23 marked this pull request as ready for review July 22, 2026 19:59
@github-actions
github-actions Bot requested a review from shuyama1 July 22, 2026 20:00
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGC failure is not related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants