Make Organization field in subjectConfig optional when creating certs#18353
Conversation
Remove requirement to specify organization when providing an x509 subject when creating a certificate.
Added a test to confirm a certificate can be created without specifying an organization in the subject field.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1680b73: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @rohanchawla23 VCR tests complete for 1680b73! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 15ed47d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @rohanchawla23 VCR tests complete for 15ed47d! |
|
terraform-google-conversion-test-integration failure can be ignored. Failing due to issues in other services (container, secretmanager, workbench, dataplex, compute). All privateca tests pass. |
|
Otherwise, LGTM! |
Changed test name to more exactly describe what its testing.
…a23/magic-modules into cas-cert-org-optional
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7210d00: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @rohanchawla23 VCR tests complete for 7210d00! |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
b31e1bc
Previously it was required to specify the organization name when using an x509 subject config to create a Certificate. This requirement is not enforced anywhere else in our service (including gcloud and UI) so it is being removed from the Terraform surface to allow for more flexible use cases.
I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.