Light metadata fixes - #7089
Merged
Merged
Conversation
We have required an internal shader node since c204f35.
The stray registration was overriding the registration at line 148, and preventing our usual `light:{name}:{parameterName}` registrations from working.
All but one of these was provided by LightUI already, and the other should be in LightUI anyway.
This is overridden on line 171.
murraystevenson
force-pushed
the
lightMetadataFixes
branch
from
August 10, 2026 22:02
0a44c33 to
2b633ed
Compare
murraystevenson
approved these changes
Aug 10, 2026
murraystevenson
left a comment
murraystevenson
left a comment
Contributor
There was a problem hiding this comment.
Thanks John, LGTM.
github-project-automation
Bot
moved this from Pending Review
to Pending release
in Work in Progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes for light metadata lookups.