fix: guard against None message before accessing .content#1369
Open
qizwiz wants to merge 1 commit into
Open
Conversation
The existing guards check response.choices[0].message.content but if message itself is None (returned by some providers on content-filtered responses with HTTP 200), this crashes with AttributeError before the guard can fire. Extend both guard conditions to check message is None first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend two guard conditions in
app/llm.pyto also checkchoices[0].message is Nonebefore accessing.content.Why
The existing guards:
protect against an empty choices list and empty/None content, but if
choices[0].messageisNone(returned by some providers on content-filtered responses with HTTP 200, e.g. Gemini PROHIBITED_CONTENT), accessing.contentraisesAttributeError: 'NoneType' object has no attribute 'content'before the guard evaluates.Fix
Both occurrences (~line 425 and ~line 595) are fixed. No behaviour change for well-formed responses.