fix: sync README config examples and make Daytona optional#1368
Open
Caldalis wants to merge 2 commits into
Open
fix: sync README config examples and make Daytona optional#1368Caldalis wants to merge 2 commits into
Caldalis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the configuration examples in all README files with the current default
config/config.example.toml, and make Daytona configuration optionalwhen no
[daytona]section is provided.The READMEs still showed the old OpenAI
gpt-4oexample, while the default config now uses Anthropic Claude. Also, loading the default configcould fail because
DaytonaSettings.daytona_api_keywas required even thoughconfig.example.tomldoes not include Daytona settings.Changes
README.mdREADME_zh.mdREADME_ko.mdREADME_ja.mdconfig/DaytonaSettings.daytona_api_keydefault to an empty stringValidation
git diff --checkpython -m py_compile app\config.pyconfig/config.example.tomlgpt-4oconfig snippet