Pass --git-no-verify info to convention scripts - #54
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the executable-convention script input contract so convention scripts can detect when the CLI was run with --git-no-verify and, when they create their own commits/pushes, pass --no-verify to bypass the same hooks RepoConventions bypasses.
Changes:
- Include a
git.noVerifyboolean in the JSON input file passed toconvention.ps1. - Update/extend commit-mode tests to cover the new
git.noVerifyinput and adjust expectations for the expanded JSON payload. - Update authoring and CLI reference documentation to describe the new
gitinput contract and expected script behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/RepoConventions.Tests/ConventionExecutionTests.cs | Updates the existing script-input test expectation and adds coverage ensuring --git-no-verify flows into script input as git.noVerify. |
| src/RepoConventions/ConventionRunner.cs | Adds git.noVerify to the JSON input file written before invoking convention.ps1. |
| skills/repo-conventions/references/convention-authoring.md | Documents the expanded JSON input contract and how scripts should honor git.noVerify for their own commits/pushes. |
| skills/repo-conventions/references/cli-reference.md | Updates CLI docs to note that --git-no-verify is also exposed to convention scripts via git.noVerify. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejball
approved these changes
Jun 9, 2026
Contributor
Author
Member
|
It does, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to add Repo Conventions to reading-plan-wizard, and I used
--git-no-verifyin an attempt to bypass the Commitlint hook there. The first two commits succeeded, but it choked on the third:With this change plus Faithlife/CodingGuidelines#70, the
gitattributes-lfcommits succeed in my local reading-plan-wizard. 🥳