Props gibs should inherit velocity for most cases and prevelocity only for impact kills. - #11079
Closed
Xenthio wants to merge 4 commits into
Closed
Props gibs should inherit velocity for most cases and prevelocity only for impact kills.#11079Xenthio wants to merge 4 commits into
Xenthio wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds damage context to prop destruction so gib creation can vary behavior (notably for impact breaks) and inherit appropriate rigidbody velocities.
Changes:
- Thread
DamageInfothroughKill→OnBreakto detect impact breaks. - Extend
NetworkCreateGibs/CreateGibsto accept awasImpactflag. - Use
PreVelocity/PreAngularVelocityfor gib physics only when broken by impact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
handsomematt
force-pushed
the
pr/prevelocity-only-on-impact
branch
from
June 8, 2026 07:48
2e97483 to
f6bcada
Compare
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, prop will not have any just applied velocity handed down to their gibs, which means in basically all cases, props shot by bullets have their gibs unnaturally drop in place.
Motivation & Context
any just applied velocity is stomped by the impact damage prevelocity
Implementation Details
I added a comment in code about why I thought prevelocity was probably chosen in the first place, and why we don't need it for most cases.
This is 100% human slop, no AI did the thinking or bug finding here.
Screenshots / Videos (if applicable)
https://github.com/user-attachments/assets/5e8dc69c-c801-4059-9438-7f5fcf0f172e
(This video implement another fix for sandbox gamemode, which reorders bullet impact forces to be applied before damage, http://github.com/Facepunch/sandbox/pull/274)
Checklist