Parent decals to hitbox bone, if a hitbox is found - #278
Open
Xenthio wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves bullet impact effects on skinned meshes by using the hitbox’s bone index (when available) to parent decals/impacts to the correct bone, with a fallback to nearest-bone selection.
Changes:
- Extract bone index from the trace hitbox and pass it into
ShootEffects. - Extend
ShootEffectsto accept aboneIndexand use it to select a bone for decal parenting. - Retain a fallback path that finds the closest bone transform when no valid index is available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [Rpc.Broadcast] | ||
| public void ShootEffects( Vector3 hitpoint, bool hit, Vector3 normal, GameObject hitObject, Surface hitSurface, Vector3? origin = null, bool noEvents = false ) | ||
| public void ShootEffects( Vector3 hitpoint, bool hit, Vector3 normal, GameObject hitObject, Surface hitSurface, int boneIndex = -1, Vector3? origin = null, bool noEvents = false ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent decals to hitbox bones if found so that they follow along and look better.
Desktop.2026.06.05.-.11.51.13.10.mp4