Skip to content

Impulse needs to be applied before damage, for gibs #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xenthio wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

Impulse needs to be applied before damage, for gibs #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Code/Game/Weapon/BaseCarryable/BaseCarryable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,13 @@ public void TraceAttack( TraceAttackInfo attack )
if ( !attack.Target.IsValid() )
return;

// Impact before the damage, so the prop gets the impulse and can pass it down to gibs.
if ( attack.Target.GetComponentInChildren<Rigidbody>() is var rb && rb.IsValid() )
{
// TODO: Scale this based on damage?
rb.ApplyImpulseAt( attack.Position, Vector3.Direction( attack.Origin, attack.Position ) * rb.Mass * 100 );
Comment thread
Xenthio marked this conversation as resolved.
}
Comment thread
Xenthio marked this conversation as resolved.

// Use owner as attacker when held by a player, seated player when controlled from a
// contraption seat, or fall back to the weapon itself (standalone/world weapon)
var attacker = EffectiveAttacker;
Expand All @@ -335,12 +342,6 @@ public void TraceAttack( TraceAttackInfo attack )

dmg.OnDamage( info );
}

if ( attack.Target.GetComponentInChildren<Rigidbody>() is var rb && rb.IsValid() )
{
// TODO: Scale this based on damage?
rb.ApplyImpulseAt( attack.Position, Vector3.Direction( attack.Origin, attack.Position ) * rb.Mass * 100 );
}
}

/// <summary>
Expand Down